[all-commits] [llvm/llvm-project] b63cd4: [clangd] Rename: merge index/AST refs path-insensi...

Sam McCall via All-commits all-commits at lists.llvm.org
Mon Feb 1 06:24:50 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b63cd4db915c08e0cb4cf668a18de24b67f2c44c
      https://github.com/llvm/llvm-project/commit/b63cd4db915c08e0cb4cf668a18de24b67f2c44c
  Author: Sam McCall <sam.mccall at gmail.com>
  Date:   2021-02-01 (Mon, 01 Feb 2021)

  Changed paths:
    M clang-tools-extra/clangd/GlobalCompilationDatabase.cpp
    M clang-tools-extra/clangd/refactor/Rename.cpp
    M clang-tools-extra/clangd/support/CMakeLists.txt
    A clang-tools-extra/clangd/support/Path.cpp
    M clang-tools-extra/clangd/support/Path.h
    M clang-tools-extra/clangd/unittests/RenameTests.cpp

  Log Message:
  -----------
  [clangd] Rename: merge index/AST refs path-insensitively where needed

If you have c:\foo open, and C:\foo indexed (case difference) then these
need to be considered the same file. Otherwise we emit edits to both,
and editors do... something that isn't pretty.

Maybe more centralized normalization is called for, but it's not trivial
to do this while also being case-preserving. see
https://github.com/clangd/clangd/issues/108

Fixes https://github.com/clangd/clangd/issues/665

Differential Revision: https://reviews.llvm.org/D95759




More information about the All-commits mailing list