[all-commits] [llvm/llvm-project] 77f077: [TableGen] Don't commute isel patterns if it would...

[Craig Topper via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 77f077b8c3b2e8bbf9b160d56194312e506dfe8f
      https://github.com/llvm/llvm-project/commit/77f077b8c3b2e8bbf9b160d56194312e506dfe8f
  Author: Craig Topper <craig.topper at sifive.com>
  Date:   2021-01-31 (Sun, 31 Jan 2021)

  Changed paths:
    M llvm/utils/TableGen/CodeGenDAGPatterns.cpp

  Log Message:
  -----------
  [TableGen] Don't commute isel patterns if it would put an immAllOnesV or immAllZerosV on the left hand side.

This primarily occurs with isel patterns using vnot. This reduces
the number of variants in the isel tables.

We generally canonicalize build_vectors of constants to the RHS. I think
we might fail if there is a bitcast on the build_vector, but that
should be easy to fix if we can find a case. Usually the
bitcast is introduced by type legalization or lowering. It's
likely canonicalization would have already occured.