[all-commits] [llvm/llvm-project] 719f77: [VFS] Combine VFSFromYamlDirIterImpl and OverlayFS...

[Nathan Hawes via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 719f778441750dcadcf7c7c411d1cfb39029d59a
      https://github.com/llvm/llvm-project/commit/719f778441750dcadcf7c7c411d1cfb39029d59a
  Author: Nathan Hawes <nhawes at apple.com>
  Date:   2021-01-30 (Sat, 30 Jan 2021)

  Changed paths:
    M lldb/source/Host/common/FileSystem.cpp
    M llvm/include/llvm/Support/VirtualFileSystem.h
    M llvm/lib/Support/VirtualFileSystem.cpp

  Log Message:
  -----------
  [VFS] Combine VFSFromYamlDirIterImpl and OverlayFSDirIterImpl into a single implementation (NFC)

As a fixme notes, both of these directory iterator implementations are
conceptually similar and duplicate the functionality of returning and uniquing
entries across two or more directories. This patch combines them into a single
class 'CombiningDirIterImpl'.

This also drops the 'Redirecting' prefix from RedirectingDirEntry and
RedirectingFileEntry to save horizontal space. There's no loss of clarity as
they already have to be prefixed with 'RedirectingFileSystem::' whenever
they're referenced anyway.

rdar://problem/72485443
Differential Revision: https://reviews.llvm.org/D94857