[all-commits] [llvm/llvm-project] 7d1b49: Revert "[clangd] Extract symbol-scope logic out of...

[Sam McCall via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7d1b499caef6ebde09a2697a97b43b89f7fa35c8
      https://github.com/llvm/llvm-project/commit/7d1b499caef6ebde09a2697a97b43b89f7fa35c8
  Author: Sam McCall <sam.mccall at gmail.com>
  Date:   2021-01-29 (Fri, 29 Jan 2021)

  Changed paths:
    M clang-tools-extra/clangd/AST.cpp
    M clang-tools-extra/clangd/AST.h
    M clang-tools-extra/clangd/CodeComplete.cpp
    M clang-tools-extra/clangd/Quality.cpp
    M clang-tools-extra/clangd/Quality.h
    M clang-tools-extra/clangd/quality/CompletionModelCodegen.py
    M clang-tools-extra/clangd/quality/model/features.json
    M clang-tools-extra/clangd/unittests/ASTTests.cpp
    M clang-tools-extra/clangd/unittests/QualityTests.cpp

  Log Message:
  -----------
  Revert "[clangd] Extract symbol-scope logic out of Quality, add tests. NFC"

On second thought, this can't properly be reused for highlighting.

Consider this example, which Quality wants to consider function-scope,
but highlighting must consider class-scope:

void foo() {
  class X {
    int ^y;
  };
}