[all-commits] [llvm/llvm-project] f84efe: [X86][AVX] combineHorizOpWithShuffle - fix valuety...

Simon Pilgrim via All-commits all-commits at lists.llvm.org
Thu Jan 28 08:37:07 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f84efe97bce138af0f8e21d3a03b7c5be168705b
      https://github.com/llvm/llvm-project/commit/f84efe97bce138af0f8e21d3a03b7c5be168705b
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2021-01-28 (Thu, 28 Jan 2021)

  Changed paths:
    M llvm/lib/Target/X86/X86ISelLowering.cpp

  Log Message:
  -----------
  [X86][AVX] combineHorizOpWithShuffle - fix valuetype comparison typo.

Ensure we check the valuetypes of all the HOP(SHUFFLE(X,Y),SHUFFLE(X,Y)) shuffle input ops - there was a copy+paste typo (noticed by MSVC analyzer) that meant we were checking the same input from one of the shuffles twice.

I haven't been able to create a test case for this yet - I don't think its currently possible to create a target/faux binary shuffle that scales to a 2x128 shuffle mask from two different value types.




More information about the All-commits mailing list