[all-commits] [llvm/llvm-project] d0c9fb: [mlir][Linalg] Improve codegen strategy

Nicolas Vasilache via All-commits all-commits at lists.llvm.org
Thu Jan 28 03:03:37 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d0c9fb1b8ebf50ea8b489354b946da961a384c8b
      https://github.com/llvm/llvm-project/commit/d0c9fb1b8ebf50ea8b489354b946da961a384c8b
  Author: Nicolas Vasilache <nicolas.vasilache at gmail.com>
  Date:   2021-01-28 (Thu, 28 Jan 2021)

  Changed paths:
    M mlir/include/mlir/Dialect/Linalg/IR/LinalgNamedStructuredOpsSpec.tc
    M mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOps.td
    A mlir/integration_test/Dialect/Linalg/CPU/benchmark_matmul.mlir
    A mlir/integration_test/Dialect/Linalg/CPU/benchmark_matmul_column_major.mlir
    A mlir/integration_test/Dialect/Linalg/CPU/benchmark_matmul_column_major_as_row_major.mlir
    M mlir/lib/Dialect/Linalg/Transforms/CodegenStrategy.cpp
    M mlir/lib/Dialect/Linalg/Transforms/Vectorization.cpp
    M mlir/test/CMakeLists.txt
    M mlir/test/Dialect/Linalg/codegen-strategy.mlir
    M mlir/test/lib/Transforms/TestLinalgCodegenStrategy.cpp
    R mlir/test/mlir-cpu-runner/CMakeLists.txt
    R mlir/test/mlir-cpu-runner/include/mlir_test_cblas.h
    R mlir/test/mlir-cpu-runner/include/mlir_test_cblas_interface.h
    R mlir/test/mlir-cpu-runner/linalg_integration_test.mlir
    R mlir/test/mlir-cpu-runner/mlir_test_cblas.cpp
    R mlir/test/mlir-cpu-runner/mlir_test_cblas_interface.cpp

  Log Message:
  -----------
  [mlir][Linalg] Improve codegen strategy

This revision improves the usage of the codegen strategy by adding a few flags that
make it easier to control for the CLI.
Usage of ModuleOp is replaced by FuncOp as this created issues in multi-threaded mode.

A simple benchmarking capability is added for linalg.matmul as well as linalg.matmul_column_major.
This latter op is also added to linalg.

Now obsolete linalg integration tests that also take too long are deleted.

Correctness checks are still missing at this point.

Differential revision: https://reviews.llvm.org/D95531




More information about the All-commits mailing list