[all-commits] [llvm/llvm-project] af2023: [clangd] Treat "null" optional fields as missing

kadir ├žetinkaya via All-commits all-commits at lists.llvm.org
Wed Jan 27 06:57:42 PST 2021

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: af20232b8e189335da571f48c2467b244b7fd772
  Author: Kadir Cetinkaya <kadircet at google.com>
  Date:   2021-01-27 (Wed, 27 Jan 2021)

  Changed paths:
    M clang-tools-extra/clangd/Protocol.cpp

  Log Message:
  [clangd] Treat "null" optional fields as missing

Clangd currently throws away any protocol messages whenever an optional
field has an unexpected type. This patch changes the behaviour to treat
`null` fields as missing.

This enables clangd to be more tolerant against small violations to the
LSP spec.

Fixes https://github.com/clangd/vscode-clangd/issues/134

Differential Revision: https://reviews.llvm.org/D95229

More information about the All-commits mailing list