[all-commits] [llvm/llvm-project] e87858: Revert "[flang] Search for #include "file" in righ...

Andrzej WarzyƄski via All-commits all-commits at lists.llvm.org
Tue Jan 26 05:07:40 PST 2021

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e878589098c2ed510159e67d9c6c5e0f3dfbf5a6
  Author: Andrzej Warzynski <andrzej.warzynski at arm.com>
  Date:   2021-01-26 (Tue, 26 Jan 2021)

  Changed paths:
    M flang/include/flang/Parser/provenance.h
    M flang/include/flang/Parser/source.h
    M flang/lib/Parser/parsing.cpp
    M flang/lib/Parser/preprocessor.cpp
    M flang/lib/Parser/prescan.cpp
    M flang/lib/Parser/provenance.cpp
    M flang/lib/Parser/source.cpp
    M flang/tools/f18/f18.cpp

  Log Message:
  Revert "[flang] Search for #include "file" in right directory"

This reverts commit d987b61b1dce9948801ac37704477e7c257100b1.

As pointed out in https://reviews.llvm.org/D95388, the reverted commit
causes build failures in the following Flang buildbots:
  * http://lab.llvm.org:8011/#/builders/32/builds/2642
  * http://lab.llvm.org:8011/#/builders/33/builds/2131
  * http://lab.llvm.org:8011/#/builders/135/builds/1473
  * http://lab.llvm.org:8011/#/builders/66/builds/1559
  * http://lab.llvm.org:8011/#/builders/134/builds/1409
  * http://lab.llvm.org:8011/#/builders/132/builds/1817
I'm guessing that the patch was only tested with
`FLANG_BUILD_NEW_DRIVER=Off` (i.e. the default). The builders listed
above set `FLANG_BUILD_NEW_DRIVER` to `On`.

Although fixing the build is relatively easy, the reverted patch
modifies the behaviour of the frontend, which breaks driver tests. In
particular, in https://reviews.llvm.org/D93453 support for `-I` was
added that depends on the current behaviour. The reverted patch
changes that behaviour. Either the tests have to be updated or the
change fine-tuned.

More information about the All-commits mailing list