[all-commits] [llvm/llvm-project] d705c2: Revert "[WebAssembly] MC layer writes table symbol...

Sam Clegg via All-commits all-commits at lists.llvm.org
Mon Jan 25 22:36:22 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d705c2fbd48708caa68d1a035b5f31660b375115
      https://github.com/llvm/llvm-project/commit/d705c2fbd48708caa68d1a035b5f31660b375115
  Author: Sam Clegg <sbc at chromium.org>
  Date:   2021-01-25 (Mon, 25 Jan 2021)

  Changed paths:
    M llvm/lib/MC/WasmObjectWriter.cpp
    M llvm/test/MC/WebAssembly/debug-info.ll
    M llvm/test/MC/WebAssembly/debug-info64.ll
    M llvm/test/MC/WebAssembly/function-alias.ll
    M llvm/test/MC/WebAssembly/global-ctor-dtor.ll
    M llvm/test/MC/WebAssembly/reloc-pic.s
    M llvm/test/MC/WebAssembly/type-index.s
    M llvm/test/MC/WebAssembly/weak-alias.s

  Log Message:
  -----------
  Revert "[WebAssembly] MC layer writes table symbols to object files"

This reverts commit d806618636f8a82bfc3f620e1fad83af4d2a2575.
Review: https://reviews.llvm.org/D92215

We had issues where older versions of wasm-ld were crashing on object
files containing a table symbol.  We decided that the best strategy
going forward is to only generate these symbol if refernece types is
enabled.  Without reference types enabled we should never geneate a
table symbol or a TABLE_NUMBER relocation.

This revert is in addition to the one already reverted in
https://reviews.llvm.org/D95005.

The plan is to re-land these in updated form after the llvm 12 branch.

Differential Revision: https://reviews.llvm.org/D95420




More information about the All-commits mailing list