[all-commits] [llvm/llvm-project] 8d67b9: SourceManager: Migrate to FileEntryRef in getOrCre...

Duncan P. N. Exon Smith via All-commits all-commits at lists.llvm.org
Mon Jan 25 17:05:01 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8d67b9e2461d654c0a3657e511e2295006f23748
      https://github.com/llvm/llvm-project/commit/8d67b9e2461d654c0a3657e511e2295006f23748
  Author: Duncan P. N. Exon Smith <dexonsmith at apple.com>
  Date:   2021-01-25 (Mon, 25 Jan 2021)

  Changed paths:
    M clang/include/clang/Basic/SourceManager.h
    M clang/lib/Basic/SourceManager.cpp
    M clang/lib/Serialization/ASTReader.cpp

  Log Message:
  -----------
  SourceManager: Migrate to FileEntryRef in getOrCreateContentCache, NFC

Change `SourceManager::getOrCreateContentCache` to take a `FileEntryRef`
and update call sites (mostly internal to SourceManager.cpp). In a
couple of cases this temporarily relies on `FileEntry::getLastRef`, but
those can be cleaned up once other APIs switch over.

The one change outside of SourceManager.cpp is in ASTReader.cpp, which
stops relying on the auto-degrade-to-`FileEntry*` behaviour from
`InputFile::getFile` since it now needs a `FileEntryRef`.

No functionality change here.

Differential Revision: https://reviews.llvm.org/D92983




More information about the All-commits mailing list