[all-commits] [llvm/llvm-project] e9cc5f: [scudo][standalone] Enable death tests on Fuchsia

Kostya Kortchinsky via All-commits all-commits at lists.llvm.org
Mon Jan 25 09:20:13 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e9cc5fef64631a16f284e5dc09a2eaa8fd34a4a1
      https://github.com/llvm/llvm-project/commit/e9cc5fef64631a16f284e5dc09a2eaa8fd34a4a1
  Author: Kostya Kortchinsky <kostyak at google.com>
  Date:   2021-01-25 (Mon, 25 Jan 2021)

  Changed paths:
    M compiler-rt/lib/scudo/standalone/tests/scudo_unit_test.h
    M compiler-rt/lib/scudo/standalone/tests/wrappers_c_test.cpp

  Log Message:
  -----------
  [scudo][standalone] Enable death tests on Fuchsia

zxtest doesn't have `EXPECT_DEATH` and the Scudo unit-tests were
defining it as a no-op.

This enables death tests on Fuchsia by using `ASSERT_DEATH` instead.
I used a lambda to wrap the expressions as this appears to not be
working the same way as `EXPECT_DEATH`.

Additionnally, a death test using `alarm` was failing with the change,
as it's currently not implemented in Fuchsia, so move that test within
a `!SCUDO_FUCHSIA` block.

Differential Revision: https://reviews.llvm.org/D94362




More information about the All-commits mailing list