[all-commits] [llvm/llvm-project] 9e708a: [COFF] Fix relocation offsets in pdb-file-statics ...

Reid Kleckner via All-commits all-commits at lists.llvm.org
Wed Jan 20 11:50:38 PST 2021


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 9e708ac6b9929e9baa2017ff62f2353e6621a105
      https://github.com/llvm/llvm-project/commit/9e708ac6b9929e9baa2017ff62f2353e6621a105
  Author: Reid Kleckner <rnk at google.com>
  Date:   2021-01-20 (Wed, 20 Jan 2021)

  Changed paths:
    M lld/test/COFF/Inputs/pdb-file-statics-a.yaml

  Log Message:
  -----------
  [COFF] Fix relocation offsets in pdb-file-statics test input

The relocation offsets were incorrect. I fixed them with llvm-readobj
-codeview -codeview-subsection-bytes, which has a helpful printout of
the relocations that apply to a given symbol record with their offsets.
With this, I was able to update the relocation offsets in the yaml to
fix the line table and the S_DEFRANGE_REGISTER records.

There is still some remaining inconsistency in yaml2obj and obj2yaml
when round tripping MSVC objects, but that isn't a blocker for relanding
D94267.




More information about the All-commits mailing list