[all-commits] [llvm/llvm-project] 6c1bc0: [docs] Fix overly specific link to uploading patch...

Louis Dionne via All-commits all-commits at lists.llvm.org
Wed Jan 20 08:19:26 PST 2021


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 6c1bc0d24ceacfe736de4fd29a21b91125125a1f
      https://github.com/llvm/llvm-project/commit/6c1bc0d24ceacfe736de4fd29a21b91125125a1f
  Author: Louis Dionne <ldionne.2 at gmail.com>
  Date:   2021-01-20 (Wed, 20 Jan 2021)

  Changed paths:
    M llvm/docs/Contributing.rst

  Log Message:
  -----------
  [docs] Fix overly specific link to uploading patches on Phabricator

The documentation for contributing to LLVM currently links to the section
explaining how to submit a Phabricator review using the web interface.
I believe it would be better to link to the general page for using
Phabricator instead, which explains how to sign up with Phabricator,
and also how to submit patches using either the web interface or the
command-line.

I think this is worth changing because what currently *appears* to be our
preferred way of submitting a patch (through the web interface) isn't
actually what we prefer. Indeed, patches submitted from the command-line
have more meta-data available (such as which repository the patch targets),
and also can't suffer from missing context.

Differential Revision: https://reviews.llvm.org/D94929




More information about the All-commits mailing list