[all-commits] [llvm/llvm-project] ec8771: [ThinLTO] Also prune Thin-* files from the ThinLTO...

[Hans via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ec877106a38b760229a2d676b7d2278b2bade8ab
      https://github.com/llvm/llvm-project/commit/ec877106a38b760229a2d676b7d2278b2bade8ab
  Author: Hans Wennborg <hans at chromium.org>
  Date:   2021-01-19 (Tue, 19 Jan 2021)

  Changed paths:
    M lld/test/COFF/lto-cache.ll
    M llvm/lib/Support/CachePruning.cpp

  Log Message:
  -----------
  [ThinLTO] Also prune Thin-* files from the ThinLTO cache

Such files (Thin-%%%%%%.tmp.o) are supposed to be deleted immediately
after they're used (either by renaming or deletion). However, we've seen
instances on Windows where this doesn't happen, probably due to the
filesystem being flaky. This is effectively a resource leak which has
prevented us from using the ThinLTO cache on Windows.

Since those temporary files are in the thinlto cache directory which we
prune periodically anyway, allowing them to be pruned too seems like a
tidy way to solve the problem.

Differential revision: https://reviews.llvm.org/D94962