[all-commits] [llvm/llvm-project] 840a2c: [CMake] Fix incorrect rpath for tests if LLVM_LOCA...

Raul Tambre via All-commits all-commits at lists.llvm.org
Fri Jan 8 11:24:36 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 840a2c978374ccc74a0e0b2576c1027fdb609a59
      https://github.com/llvm/llvm-project/commit/840a2c978374ccc74a0e0b2576c1027fdb609a59
  Author: Raul Tambre <raul at tambre.ee>
  Date:   2021-01-08 (Fri, 08 Jan 2021)

  Changed paths:
    M llvm/cmake/modules/AddLLVM.cmake

  Log Message:
  -----------
  [CMake] Fix incorrect rpath for tests if LLVM_LOCAL_RPATH isn't set

d9ce31ae7d (D94322) removed the check because I thought it was dead
due to checking the existance of a variable (which always existed).

This causes LLDB tests to fail as they set NO_INSTALL_RPATH because
they're never meant to be installed, but we still would end up using
the install rpath.

Add the check back and make it explicitly check for an empty value
to make the purpose clearer and avoid implicit test for a false/true
value.

Differential Revision: https://reviews.llvm.org/D94326




More information about the All-commits mailing list