[all-commits] [llvm/llvm-project] b12f26: Revert "Revert "Revert "[analyzer] NFC: Move path ...

[David Blaikie via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b12f26733a4259c90e5f387aceb9f23c35e003b8
      https://github.com/llvm/llvm-project/commit/b12f26733a4259c90e5f387aceb9f23c35e003b8
  Author: David Blaikie <dblaikie at gmail.com>
  Date:   2021-01-07 (Thu, 07 Jan 2021)

  Changed paths:
    R clang/include/clang/Analysis/CrossTUAnalysisHelper.h
    R clang/include/clang/Analysis/PathDiagnosticConsumers.def
    R clang/include/clang/Analysis/PathDiagnosticConsumers.h
    M clang/include/clang/CrossTU/CrossTranslationUnit.h
    M clang/include/clang/StaticAnalyzer/Core/Analyses.def
    M clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
    A clang/include/clang/StaticAnalyzer/Core/PathDiagnosticConsumers.h
    M clang/include/clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h
    M clang/include/clang/module.modulemap
    M clang/lib/Analysis/CMakeLists.txt
    R clang/lib/Analysis/HTMLPathDiagnosticConsumer.cpp
    R clang/lib/Analysis/PlistHTMLPathDiagnosticConsumer.cpp
    R clang/lib/Analysis/PlistPathDiagnosticConsumer.cpp
    R clang/lib/Analysis/SarifPathDiagnosticConsumer.cpp
    R clang/lib/Analysis/TextPathDiagnosticConsumer.cpp
    M clang/lib/CrossTU/CrossTranslationUnit.cpp
    M clang/lib/Frontend/CompilerInvocation.cpp
    M clang/lib/StaticAnalyzer/Core/CMakeLists.txt
    A clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp
    A clang/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp
    A clang/lib/StaticAnalyzer/Core/SarifDiagnostics.cpp
    A clang/lib/StaticAnalyzer/Core/TextDiagnostics.cpp
    M clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp

  Log Message:
  -----------
  Revert "Revert "Revert "[analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis."""

This reverts commit d2ddc694ff94743d9735aaf07edcaf6db8aaca04.

This still contains a circular dependency between Analysis and CrossTU:

$ grep -r include.*Analysis clang/include/clang/CrossTU
clang/include/clang/CrossTU/CrossTranslationUnit.h:
  #include "clang/Analysis/CrossTUAnalysisHelper.h"
$ grep -r include.*CrossTU clang/lib/Analysis
clang/lib/Analysis/PlistHTMLPathDiagnosticConsumer.cpp:
  #include "clang/CrossTU/CrossTranslationUnit.h"
clang/lib/Analysis/PlistPathDiagnosticConsumer.cpp:
  #include "clang/Analysis/CrossTUAnalysisHelper.h"