[all-commits] [llvm/llvm-project] db33f8: [IR] Use LLVM_ENABLE_ABI_BREAKING_CHECKS to guard ...

Varun Gandhi via All-commits all-commits at lists.llvm.org
Thu Jan 7 08:42:23 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: db33f85c7124443e140d0118289fc141bab0c68d
      https://github.com/llvm/llvm-project/commit/db33f85c7124443e140d0118289fc141bab0c68d
  Author: Varun Gandhi <varun_gandhi at apple.com>
  Date:   2021-01-07 (Thu, 07 Jan 2021)

  Changed paths:
    M llvm/include/llvm/IR/ValueHandle.h

  Log Message:
  -----------
  [IR] Use LLVM_ENABLE_ABI_BREAKING_CHECKS to guard ABI changes.

Incorrect usage of NDEBUG to guard ABI changes can prevent clients
from enabling assertions for their C++ code while having assertions in
LLVM turned off. So we use LLVM_ENABLE_ABI_BREAKING_CHECKS instead, as
described in llvm/docs/ProgrammersManual.rst. Most types already use this
macro, however, there were a couple of stragglers in ValueHandle.h, which
are fixed by this revision.

Reviewed By: dblaikie, dexonsmith

Differential Revision: https://reviews.llvm.org/D93433




More information about the All-commits mailing list