[all-commits] [llvm/llvm-project] ebfe4d: [DDG] Fix duplicate edge removal during pi-block f...

Bardia Mahjour via All-commits all-commits at lists.llvm.org
Thu Jan 7 07:35:42 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ebfe4de2c04b09d3ae935325e6c02c68f2965b00
      https://github.com/llvm/llvm-project/commit/ebfe4de2c04b09d3ae935325e6c02c68f2965b00
  Author: Bardia Mahjour <bmahjour at ca.ibm.com>
  Date:   2021-01-07 (Thu, 07 Jan 2021)

  Changed paths:
    M llvm/lib/Analysis/DependenceGraphBuilder.cpp
    M llvm/unittests/Analysis/DDGTest.cpp

  Log Message:
  -----------
  [DDG] Fix duplicate edge removal during pi-block formation

When creating pi-blocks we try to avoid creating duplicate edges
between outside nodes and the pi-block when an edge is of the
same kind and direction as another one that has already been
created. We do this by keeping track of the edges in an
enumerated array called EdgeAlreadyCreated. The problem is that
this array is declared local to the loop that iterates over the
nodes in the pi-block, so the information gets lost every time a
new inside-node is iterated over. The fix is to move the
declaration to the outer loop.

Reviewed By: Meinersbur

Differential Revision: https://reviews.llvm.org/D94094




More information about the All-commits mailing list