[all-commits] [llvm/llvm-project] 8dee0b: [llvm-reduce] ReduceGlobalVarInitializers delta pa...

[Roman Lebedev via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8dee0b4bd6376f5518accf45e9ecc4a44a4c8481
      https://github.com/llvm/llvm-project/commit/8dee0b4bd6376f5518accf45e9ecc4a44a4c8481
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2021-01-07 (Thu, 07 Jan 2021)

  Changed paths:
    M llvm/test/Reduce/remove-global-vars.ll
    M llvm/tools/llvm-reduce/deltas/ReduceGlobalVarInitializers.cpp

  Log Message:
  -----------
  [llvm-reduce] ReduceGlobalVarInitializers delta pass: fix handling of globals w/ comdat/non-external linkage

Much like with ReduceFunctionBodies delta pass,
we need to remove comdat and set linkage to external,
else verifier will complain, and our deltas are invalid.


  Commit: 6be1fd6b20f3418543a50ce9b04ab4a49585a7eb
      https://github.com/llvm/llvm-project/commit/6be1fd6b20f3418543a50ce9b04ab4a49585a7eb
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2021-01-07 (Thu, 07 Jan 2021)

  Changed paths:
    M llvm/lib/Transforms/Utils/SimplifyCFG.cpp
    A llvm/test/Transforms/SimplifyCFG/FoldValueComparisonIntoPredecessors-no-new-successors.ll

  Log Message:
  -----------
  [SimplifyCFG] FoldValueComparisonIntoPredecessors(): drop reachable errneous assert

I have added it in d15d81c because it *seemed* correct, was holding
for all the tests so far, and was validating the fix added in the same
commit, but as David Major is pointing out (with a reproducer),
the assertion isn't really correct after all. So remove it.

Note that the d15d81c still fine.


Compare: https://github.com/llvm/llvm-project/compare/048f184ee488...6be1fd6b20f3