[all-commits] [llvm/llvm-project] 213329: [clangd] Add server capability advertising hot-rel...

Sam McCall via All-commits all-commits at lists.llvm.org
Thu Jan 7 04:39:48 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 213329d7c64f9710f23a78596255509b147b37c6
      https://github.com/llvm/llvm-project/commit/213329d7c64f9710f23a78596255509b147b37c6
  Author: Sam McCall <sam.mccall at gmail.com>
  Date:   2021-01-07 (Thu, 07 Jan 2021)

  Changed paths:
    M clang-tools-extra/clangd/ClangdLSPServer.cpp
    M clang-tools-extra/clangd/test/initialize-params.test

  Log Message:
  -----------
  [clangd] Add server capability advertising hot-reloading of CDBs.

Currently some clients watch for CDB changes and restart clangd, now that we
can reload compile_commands.json ourselves this is counterproductive.
The capability allows this behavior to be phased out.

This is going to be a mild regression, as we do not actually watch for files on
disk and so new diagnostics need to wait until a rebuild is requested e.g. due
to file change (and the internal caches have expired).
However this is still a better tradeoff (and if it's important, we can request
the client to watch files for us in the future).

Differential Revision: https://reviews.llvm.org/D94222




More information about the All-commits mailing list