[all-commits] [llvm/llvm-project] 37e83b: [NFC] Move readAPValue/writeAPValue up the inherit...

Varun Gandhi via All-commits all-commits at lists.llvm.org
Wed Jan 6 16:45:09 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 37e83bc6db3ad7d9a5d182694ebe71ebbc6120de
      https://github.com/llvm/llvm-project/commit/37e83bc6db3ad7d9a5d182694ebe71ebbc6120de
  Author: Varun Gandhi <varun_gandhi at apple.com>
  Date:   2021-01-06 (Wed, 06 Jan 2021)

  Changed paths:
    M clang/include/clang/AST/APValue.h
    M clang/include/clang/AST/AbstractBasicReader.h
    M clang/include/clang/AST/AbstractBasicWriter.h
    M clang/include/clang/AST/PropertiesBase.td
    M clang/include/clang/Serialization/ASTRecordReader.h
    M clang/include/clang/Serialization/ASTRecordWriter.h
    M clang/include/clang/Serialization/ASTWriter.h
    M clang/lib/AST/APValue.cpp
    M clang/lib/Serialization/ASTReader.cpp
    M clang/lib/Serialization/ASTWriter.cpp
    M clang/utils/TableGen/ClangASTPropertiesEmitter.cpp

  Log Message:
  -----------
  [NFC] Move readAPValue/writeAPValue up the inheritance hierarchy

The implementation for (de)serialization of APValues can be shared
between Clang and Swift, so we prefer pushing the methods up
the inheritance hierarchy, instead of having the methods live in
ASTReader/ASTWriter. Fixes rdar://72592937.

Reviewed By: rjmccall

Differential Revision: https://reviews.llvm.org/D94196




More information about the All-commits mailing list