[all-commits] [llvm/llvm-project] b37de2: [Support] Untie the llvm::Signpost interface from ...

[Jonas Devlieghere via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b37de2afa30fe4312aa9b87b11208bd7e05c8fa1
      https://github.com/llvm/llvm-project/commit/b37de2afa30fe4312aa9b87b11208bd7e05c8fa1
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2021-01-06 (Wed, 06 Jan 2021)

  Changed paths:
    M llvm/include/llvm/Support/Signposts.h
    M llvm/lib/Support/Signposts.cpp
    M llvm/lib/Support/Timer.cpp

  Log Message:
  -----------
  [Support] Untie the llvm::Signpost interface from llvm::Timer

Make llvm::Signpost more generic by untying from llvm::Timer. This
allows signposts to be used in a different context.

My motivation for doing this is being able to use signposts in LLDB.

Differential revision: https://reviews.llvm.org/D93655


  Commit: 6d94eeadd28af4d488b5875778a3ebfa0d749b52
      https://github.com/llvm/llvm-project/commit/6d94eeadd28af4d488b5875778a3ebfa0d749b52
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2021-01-06 (Wed, 06 Jan 2021)

  Changed paths:
    M lldb/include/lldb/Utility/Timer.h
    M lldb/source/Utility/Timer.cpp

  Log Message:
  -----------
  [lldb] Ad os_signpost support to lldb_private::Timer

Emit os_signposts when supported from LLDB's timer class. A vast amount
of performance sensitive places in LLDB are already instrumented with
the Timer class.

By emitting signposts we can examine this information in Instruments. I
recommend looking at Daniel's differential for why this is so powerful:
https://reviews.llvm.org/D52954.

Differential revision: https://reviews.llvm.org/D93657


Compare: https://github.com/llvm/llvm-project/compare/080943f7525f...6d94eeadd28a