[all-commits] [llvm/llvm-project] e0a93e: [mlir][ODS] Rename several uses of 'description' t...

[River Riddle via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: e0a93e4b65b63b0ae0fbde826790dc1728789fab
      https://github.com/llvm/llvm-project/commit/e0a93e4b65b63b0ae0fbde826790dc1728789fab
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2021-01-06 (Wed, 06 Jan 2021)

  Changed paths:
    M mlir/docs/OpDefinitions.md
    M mlir/include/mlir/Dialect/ArmSVE/ArmSVE.td
    M mlir/include/mlir/Dialect/Async/IR/AsyncBase.td
    M mlir/include/mlir/Dialect/LLVMIR/LLVMOpBase.td
    M mlir/include/mlir/Dialect/Quant/QuantOpsBase.td
    M mlir/include/mlir/Dialect/Shape/IR/ShapeBase.td
    M mlir/include/mlir/Dialect/Tosa/IR/TosaOpBase.td
    M mlir/include/mlir/IR/OpBase.td
    M mlir/include/mlir/TableGen/Constraint.h
    M mlir/include/mlir/TableGen/OpTrait.h
    M mlir/include/mlir/TableGen/Type.h
    M mlir/include/mlir/TableGen/TypeDef.h
    M mlir/lib/TableGen/Constraint.cpp
    M mlir/lib/TableGen/OpTrait.cpp
    M mlir/lib/TableGen/Type.cpp
    M mlir/lib/TableGen/TypeDef.cpp
    M mlir/test/mlir-tblgen/op-attribute.td
    M mlir/tools/mlir-tblgen/EnumsGen.cpp
    M mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp
    M mlir/tools/mlir-tblgen/OpDocGen.cpp
    M mlir/tools/mlir-tblgen/OpFormatGen.cpp
    M mlir/tools/mlir-tblgen/RewriterGen.cpp
    M mlir/tools/mlir-tblgen/StructsGen.cpp
    M mlir/unittests/TableGen/structs.td

  Log Message:
  -----------
  [mlir][ODS] Rename several uses of 'description' to 'summary'

Right now constraint/predicate traits/etc. use their "description" field as a one line human readable string. This breaks the current convention, by which a "description" may be multi-line. This revision renames the "description" field in these cases to "summary" which matches what the string is actually used as. This also unbreaks the use of TypeDefs(and eventually AttrDefs) in conjunction with existing type constraint facilities like `Optional`.

Differential Revision: https://reviews.llvm.org/D94133


  Commit: c42cee0c64fe20235123ba44aac12d7e38117a7e
      https://github.com/llvm/llvm-project/commit/c42cee0c64fe20235123ba44aac12d7e38117a7e
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2021-01-06 (Wed, 06 Jan 2021)

  Changed paths:
    M mlir/include/mlir/IR/OpBase.td
    M mlir/include/mlir/TableGen/Type.h
    M mlir/lib/TableGen/Type.cpp
    M mlir/test/mlir-tblgen/op-decl.td

  Log Message:
  -----------
  [mlir][ODS] Fix the use of cppClassName in Type constraints for TypeDefs

This field is currently being used to mean "Fully resolved class name", which breaks the usage by TypeDefs. This revision prefixes the name with the dialect namespace when necessary.

Differential Revision: https://reviews.llvm.org/D94192


Compare: https://github.com/llvm/llvm-project/compare/4726bec8f29b...c42cee0c64fe