[all-commits] [llvm/llvm-project] 2a29ce: [hip] Fix HIP version parsing.
darkbuck via All-commits
all-commits at lists.llvm.org
Wed Jan 6 14:05:21 PST 2021
Branch: refs/heads/master
Home: https://github.com/llvm/llvm-project
Commit: 2a29ce303451375bbf1de7c971296553ef5d9beb
https://github.com/llvm/llvm-project/commit/2a29ce303451375bbf1de7c971296553ef5d9beb
Author: Michael Liao <michael.hliao at gmail.com>
Date: 2021-01-06 (Wed, 06 Jan 2021)
Changed paths:
M clang/lib/Driver/ToolChains/AMDGPU.cpp
M clang/lib/Driver/ToolChains/ROCm.h
M clang/test/Driver/Inputs/rocm/bin/.hipVersion
Log Message:
-----------
[hip] Fix HIP version parsing.
- Need trimming before parsing major or minor version numbers. This's required
due to the different line ending on Windows.
- In addition, the integer conversion may fail due to invalid char. Return that
parsing function return `true` when the parsing fails.
Differential Revision: https://reviews.llvm.org/D93587
More information about the All-commits
mailing list