[all-commits] [llvm/llvm-project] 7a97ee: [Coroutines] checkAsyncFuncPointer - use cast<> in...

Simon Pilgrim via All-commits all-commits at lists.llvm.org
Tue Jan 5 02:36:46 PST 2021


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 7a97eeb197a8023acbb800d40b3bb852fc2f5d60
      https://github.com/llvm/llvm-project/commit/7a97eeb197a8023acbb800d40b3bb852fc2f5d60
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2021-01-05 (Tue, 05 Jan 2021)

  Changed paths:
    M llvm/lib/Transforms/Coroutines/Coroutines.cpp

  Log Message:
  -----------
  [Coroutines] checkAsyncFuncPointer - use cast<> instead of dyn_cast<> for dereferenced pointer. NFCI.

We're immediately dereferencing the casted pointer, so use cast<> which will assert instead of dyn_cast<> which can return null.

Fixes static analyzer warning.


  Commit: a000366d0502b35fc0d3b113ace7f0e3bbdc08cd
      https://github.com/llvm/llvm-project/commit/a000366d0502b35fc0d3b113ace7f0e3bbdc08cd
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2021-01-05 (Tue, 05 Jan 2021)

  Changed paths:
    M llvm/include/llvm/Transforms/Utils/SimplifyIndVar.h
    M llvm/lib/Transforms/Utils/SimplifyIndVar.cpp

  Log Message:
  -----------
  [SimplifyIndVar] createWideIV - make WideIVInfo arg a const ref. NFCI.

The WideIVInfo arg is only ever used as a const.

Fixes cppcheck warning.


Compare: https://github.com/llvm/llvm-project/compare/914066fe38a9...a000366d0502


More information about the All-commits mailing list