[all-commits] [llvm/llvm-project] 2962f1: [NFC] Add the getSizeInBytes() interface for Machi...

QingShan Zhang via All-commits all-commits at lists.llvm.org
Mon Jan 4 19:26:12 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2962f1149c8fccf8e865654ce11b3f1312165651
      https://github.com/llvm/llvm-project/commit/2962f1149c8fccf8e865654ce11b3f1312165651
  Author: QingShan Zhang <qshanz at cn.ibm.com>
  Date:   2021-01-05 (Tue, 05 Jan 2021)

  Changed paths:
    M llvm/include/llvm/CodeGen/MachineConstantPool.h
    M llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
    M llvm/lib/CodeGen/MachineFunction.cpp
    M llvm/lib/Target/ARM/ARMConstantIslandPass.cpp
    M llvm/lib/Target/Mips/MipsConstantIslandPass.cpp
    M llvm/lib/Target/X86/X86MCInstLower.cpp

  Log Message:
  -----------
  [NFC] Add the getSizeInBytes() interface for MachineConstantPoolValue

Current implementation assumes that, each MachineConstantPoolValue takes
up sizeof(MachineConstantPoolValue::Ty) bytes. For PowerPC, we want to
lump all the constants with the same type as one MachineConstantPoolValue
to save the cost that calculate the TOC entry for each const. So, we need
to extend the MachineConstantPoolValue that break this assumption.

Reviewed By: RKSimon

Differential Revision: https://reviews.llvm.org/D89108




More information about the All-commits mailing list