[all-commits] [llvm/llvm-project] 09b3f3: [benchmark] Fixed a build error when using CMake 3...
AnzhongHuang via All-commits
all-commits at lists.llvm.org
Mon Jan 4 00:06:20 PST 2021
Branch: refs/heads/master
Home: https://github.com/llvm/llvm-project
Commit: 09b3f3f22cbe159a737c44b2e78de08bbbfa5be3
https://github.com/llvm/llvm-project/commit/09b3f3f22cbe159a737c44b2e78de08bbbfa5be3
Author: AnZhong Huang <Anzhong.huang at amd.com>
Date: 2021-01-04 (Mon, 04 Jan 2021)
Changed paths:
M llvm/utils/benchmark/include/benchmark/benchmark.h
Log Message:
-----------
[benchmark] Fixed a build error when using CMake 3.15.1 + NDK-R20
std::decay_t used by llvm/utils/benchmark/include/benchmark/benchmark.h is a c++14 feature, but the CMakelist uses c++11, it's the root-cause of build error.
There are two options to fix the error.
1) change the CMakelist to support c++14.
2) change std::decay_t to std::decay, it's what the patch done.
This bug can only be reproduced by CMake 3.15, we didn't observer the bug with CMake 3.16. But based on the code's logic, it's an obvious bug of LLVM.
Reviewed By: lebedev.ri
Differential Revision: https://reviews.llvm.org/D93794
More information about the All-commits
mailing list