[all-commits] [llvm/llvm-project] c4ca10: [SLP] use switch to improve readability; NFC

RotateRight via All-commits all-commits at lists.llvm.org
Sat Dec 26 08:29:19 PST 2020


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c4ca108966926871a7e2bf362b1816be88a99162
      https://github.com/llvm/llvm-project/commit/c4ca108966926871a7e2bf362b1816be88a99162
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2020-12-26 (Sat, 26 Dec 2020)

  Changed paths:
    M llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp

  Log Message:
  -----------
  [SLP] use switch to improve readability; NFC

This will get more complicated when we handle intrinsics like maxnum.


  Commit: badf0f20f3b3e8f8f06d6c632d2c9fc8e509fd25
      https://github.com/llvm/llvm-project/commit/badf0f20f3b3e8f8f06d6c632d2c9fc8e509fd25
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2020-12-26 (Sat, 26 Dec 2020)

  Changed paths:
    M llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp

  Log Message:
  -----------
  [SLP] rename reduction variables for readability; NFC

I am hoping to extend the reduction matching code, and it is
hard to distinguish "ReductionData" from "ReducedValueData".
So extend the tree/root metaphor to include leaves.

Another problem is that the name "OperationData" does not
provide insight into its purpose. I'm not sure if we can alter
that underlying data structure to make the code clearer.


Compare: https://github.com/llvm/llvm-project/compare/c7dcc4c72588...badf0f20f3b3


More information about the All-commits mailing list