[all-commits] [llvm/llvm-project] fb4689: [Support] Explicitly state that KnownBits::getMinV...

Simon Pilgrim via All-commits all-commits at lists.llvm.org
Thu Dec 24 06:10:39 PST 2020


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: fb468953082c1fe97d42e6eabe8d3511bdb4054f
      https://github.com/llvm/llvm-project/commit/fb468953082c1fe97d42e6eabe8d3511bdb4054f
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2020-12-24 (Thu, 24 Dec 2020)

  Changed paths:
    M llvm/include/llvm/Support/KnownBits.h

  Log Message:
  -----------
  [Support] Explicitly state that KnownBits::getMinValue/getMaxValue are UNSIGNED values. NFCI.

Update the comment to make this clear, following the same approach as APInt.


  Commit: 6895581fd2c1cbe1a51d157d40219b7bb51a9cd5
      https://github.com/llvm/llvm-project/commit/6895581fd2c1cbe1a51d157d40219b7bb51a9cd5
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2020-12-24 (Thu, 24 Dec 2020)

  Changed paths:
    M llvm/include/llvm/Support/KnownBits.h
    M llvm/unittests/Support/KnownBitsTest.cpp

  Log Message:
  -----------
  [Support] Add KnownBits::getSignedMinValue/getSignedMaxValue helpers.

Add unit test coverage - a followup will update InstCombineCompares.cpp to use this and could be used by D86578 as well.


Compare: https://github.com/llvm/llvm-project/compare/ce4413e48941...6895581fd2c1


More information about the All-commits mailing list