[all-commits] [llvm/llvm-project] e07512: [CodeGen] Add "noreturn" attirbute to _Unwind_Resume

ebrevnov via All-commits all-commits at lists.llvm.org
Thu Dec 24 03:14:43 PST 2020


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e0751234ef0df733032b777ed0d993a490121855
      https://github.com/llvm/llvm-project/commit/e0751234ef0df733032b777ed0d993a490121855
  Author: Evgeniy Brevnov <ybrevnov at azul.com>
  Date:   2020-12-24 (Thu, 24 Dec 2020)

  Changed paths:
    M llvm/lib/CodeGen/DwarfEHPrepare.cpp
    M llvm/test/CodeGen/AArch64/GlobalISel/irtranslator-invoke-probabilities.ll
    A llvm/test/CodeGen/Generic/dwarf_eh_resume.ll

  Log Message:
  -----------
  [CodeGen] Add "noreturn" attirbute to _Unwind_Resume

Currently 'resume' is lowered to _Unwind_Resume with out "noreturn" attribute. Semantically _Unwind_Resume  library call is expected to never return and should be marked as such. Though I didn't find any changes in behavior of existing tests there will be a difference once https://reviews.llvm.org/D79485 lands.

I was not able to come up with the test case anything better than just checking for presence of "noreturn" attribute. Please let me know if there is a better way to test the change.

Reviewed By: xbolva00

Differential Revision: https://reviews.llvm.org/D93682




More information about the All-commits mailing list