[all-commits] [llvm/llvm-project] f80793: [InstCombine] canonicalizeAbsNabs(): don't propaga...

Roman Lebedev via All-commits all-commits at lists.llvm.org
Wed Dec 23 13:06:42 PST 2020


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f8079355c604fead0f8538548bd7eb51fcc81e31
      https://github.com/llvm/llvm-project/commit/f8079355c604fead0f8538548bd7eb51fcc81e31
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2020-12-24 (Thu, 24 Dec 2020)

  Changed paths:
    M llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp
    M llvm/test/Transforms/InstCombine/abs-1.ll
    M llvm/test/Transforms/InstCombine/abs_abs.ll
    M llvm/test/Transforms/InstCombine/select_meta.ll

  Log Message:
  -----------
  [InstCombine] canonicalizeAbsNabs(): don't propagate NSW flag for NABS patter

As Nuno is noting in post-commit review in
https://reviews.llvm.org/D87188#2467915
it is not correct to keep NSW for negated abs pattern,
so don't do that.




More information about the All-commits mailing list