[all-commits] [llvm/llvm-project] 6fcb03: Fold comparison of __builtin_object_size expressio...

[Siddhesh Poyarekar via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6fcb039956483988fa4b82a9a3944084353d00a5
      https://github.com/llvm/llvm-project/commit/6fcb039956483988fa4b82a9a3944084353d00a5
  Author: Siddhesh Poyarekar <siddhesh at redhat.com>
  Date:   2020-12-22 (Tue, 22 Dec 2020)

  Changed paths:
    M llvm/lib/Analysis/MemoryBuiltins.cpp
    M llvm/test/Transforms/InstCombine/builtin-dynamic-object-size.ll
    R llvm/test/Transforms/InstCombine/limit-max-iterations.ll

  Log Message:
  -----------
  Fold comparison of __builtin_object_size expression with -1 for non-const size

When __builtin_dynamic_object_size returns a non-constant expression, it cannot
be -1 since that is an invalid return value for object size. However since
passes running after the substitution don't know this, they are unable to
optimize away the comparison and hence the comparison and branch stays in there.
This change generates an appropriate call to llvm.assume to help the optimizer
folding the test.

glibc is considering adopting __builtin_dynamic_object_size for additional
protection[1] and this change will help reduce branching overhead in fortified
implementations of all of the functions that don't have the __builtin___*_chk
type builtins, e.g. __ppoll_chk.

Also remove the test limit-max-iterations.ll because it was deemed unnecessary
during review.

[1] https://sourceware.org/pipermail/libc-alpha/2020-November/120191.html

Differential Revision: https://reviews.llvm.org/D93015