[all-commits] [llvm/llvm-project] a6783c: [llvm][ARM/AArch64] Convert Target Parser CPU test...

David Spickett via All-commits all-commits at lists.llvm.org
Tue Dec 22 01:11:42 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: a6783cd7b65d6c739c4dc20ec5191b2e862a4237
      https://github.com/llvm/llvm-project/commit/a6783cd7b65d6c739c4dc20ec5191b2e862a4237
  Author: David Spickett <david.spickett at linaro.org>
  Date:   2020-12-22 (Tue, 22 Dec 2020)

  Changed paths:
    M llvm/unittests/Support/TargetParserTest.cpp

  Log Message:
  -----------
  [llvm][ARM/AArch64] Convert Target Parser CPU tests to fixtures

Also convert the test function to use EXPECT_EQ and
remove the special case for the AEK_NONE extension.

This means that each test is marked as failing separatley
and the accumultated EXPECT failures are printed next
to that test, with its parameters.

Before they would be hidden by the "pass &=" pattern
and failures would print in one block since it was a
"single" test.

Example of the new failure messages:
```
ARMCPUTestsPart1/ARMCPUTestFixture.ARMCPUTests/6
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from ARMCPUTestsPart1/ARMCPUTestFixture
[ RUN      ] ARMCPUTestsPart1/ARMCPUTestFixture.ARMCPUTests/6
/work/open_source/nightly-llvm/llvm-project/llvm/unittests/Support/TargetParserTest.cpp:66:
Failure
      Expected: params.ExpectedFlags
      Which is: 3405705229
To be equal to: default_extensions
      Which is: 1
[  FAILED  ] ARMCPUTestsPart1/ARMCPUTestFixture.ARMCPUTests/6, where
GetParam() = "arm8", "armv4", "none", 0xcafef00d, "4" (0 ms)
```

Reviewed By: MarkMurrayARM

Differential Revision: https://reviews.llvm.org/D93392




More information about the All-commits mailing list