[all-commits] [llvm/llvm-project] e28633: [lld-macho][nfc] Use split-file in order file test

Jez Ng via All-commits all-commits at lists.llvm.org
Sun Dec 20 10:49:47 PST 2020


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e2863357de77d6980cbb5a17605b8928d96ddd20
      https://github.com/llvm/llvm-project/commit/e2863357de77d6980cbb5a17605b8928d96ddd20
  Author: Jez Ng <jezng at fb.com>
  Date:   2020-12-20 (Sun, 20 Dec 2020)

  Changed paths:
    M lld/test/MachO/order-file.s

  Log Message:
  -----------
  [lld-macho][nfc] Use split-file in order file test

Makes it much easier to edit / maintain.

Reviewed By: #lld-macho, smeenai

Differential Revision: https://reviews.llvm.org/D93566


  Commit: 5f9896d3b23c31beecf225d90194e1bf4e097677
      https://github.com/llvm/llvm-project/commit/5f9896d3b23c31beecf225d90194e1bf4e097677
  Author: Jez Ng <jezng at fb.com>
  Date:   2020-12-20 (Sun, 20 Dec 2020)

  Changed paths:
    M lld/MachO/Driver.cpp
    R lld/test/MachO/invalid/order-file-bad-arch.test
    R lld/test/MachO/invalid/order-file-bad-objfile.test
    M lld/test/MachO/order-file.s

  Log Message:
  -----------
  [lld-macho] Support Obj-C symbols in order files

Obj-C symbols may have spaces and colons, which our previous order file
parser would be confused by. The order file format has made the very unfortunate
choice of using colons for its delimiters, which means that we have to use
heuristics to determine if a given colon is part of a symbol or not...

Reviewed By: #lld-macho, thakis

Differential Revision: https://reviews.llvm.org/D93567


  Commit: 64e47572002023d1ddd6bd12299ac12969af8665
      https://github.com/llvm/llvm-project/commit/64e47572002023d1ddd6bd12299ac12969af8665
  Author: Jez Ng <jezng at fb.com>
  Date:   2020-12-20 (Sun, 20 Dec 2020)

  Changed paths:
    M lld/MachO/Writer.cpp
    M lld/test/MachO/order-file.s

  Log Message:
  -----------
  [lld-macho] Have order files support filtering by archive member paths

Also remove iteration over ArchiveFile symbols in buildInputSectionPriorities --
that was rendered unnecessary after D92539, which included ObjFiles from
ArchiveFiles inside the `inputFiles` vector.

Reviewed By: #lld-macho, smeenai

Differential Revision: https://reviews.llvm.org/D93569


Compare: https://github.com/llvm/llvm-project/compare/43327ba98da1...64e475720020


More information about the All-commits mailing list