[all-commits] [llvm/llvm-project] a913a5: [lldb] Simplify the is_finalized logic in process ...

Jonas Devlieghere via All-commits all-commits at lists.llvm.org
Fri Dec 18 18:46:04 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: a913a583f00a31c37a1572089fe8898a6c19536c
      https://github.com/llvm/llvm-project/commit/a913a583f00a31c37a1572089fe8898a6c19536c
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2020-12-18 (Fri, 18 Dec 2020)

  Changed paths:
    M lldb/include/lldb/Target/Process.h
    M lldb/source/Target/Process.cpp

  Log Message:
  -----------
  [lldb] Simplify the is_finalized logic in process and make it thread safe.

This is a speculative fix when looking at the finalization code in
Process. It tackles the following issues:

 - Adds synchronization to prevent races between threads.
 - Marks the process as finalized/invalid as soon as Finalize is called
   rather than at the end.
 - Simplifies the code by using only a single instance variable to track
   finalization.

Differential revision: https://reviews.llvm.org/D93479




More information about the All-commits mailing list