[all-commits] [llvm/llvm-project] 9c978d: [TableGen] Fix D90844 introduced non-determinism d...

Fangrui Song via All-commits all-commits at lists.llvm.org
Fri Dec 18 12:08:37 PST 2020


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9c978dd6e12e5ffaf5441f459db47e9892b09a82
      https://github.com/llvm/llvm-project/commit/9c978dd6e12e5ffaf5441f459db47e9892b09a82
  Author: Fangrui Song <i at maskray.me>
  Date:   2020-12-18 (Fri, 18 Dec 2020)

  Changed paths:
    M llvm/utils/TableGen/CodeGenSchedule.cpp
    M llvm/utils/TableGen/CodeGenSchedule.h

  Log Message:
  -----------
  [TableGen] Fix D90844 introduced non-determinism due to iteration over a std::map over allocated object pointers

993eaf2d69d8beb97e4695cbd919b927ed1cfe86 (D90844) is still wrong.
The allocated const Record* pointers do not have an order guarantee
so switching from DenseMap to std::map does not help.

ProcModelMapTy = std::map<const Record*, unsigned>

Sort the values instead.




More information about the All-commits mailing list