[all-commits] [llvm/llvm-project] d599ed: [libc][NFC] Use ASSERT_FP_EQ to comapre NaN values...

Siva Chandra via All-commits all-commits at lists.llvm.org
Thu Dec 17 23:19:35 PST 2020


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d599ed49b355f1481bf8b22774e1a902352c9766
      https://github.com/llvm/llvm-project/commit/d599ed49b355f1481bf8b22774e1a902352c9766
  Author: Siva Chandra Reddy <sivachandra at google.com>
  Date:   2020-12-17 (Thu, 17 Dec 2020)

  Changed paths:
    M libc/test/src/math/FDimTest.h
    M libc/test/src/math/RemQuoTest.h
    M libc/test/src/math/fmax_test.cpp
    M libc/test/src/math/fmaxf_test.cpp
    M libc/test/src/math/fmaxl_test.cpp
    M libc/test/src/math/fmin_test.cpp
    M libc/test/src/math/fminf_test.cpp
    M libc/test/src/math/fminl_test.cpp

  Log Message:
  -----------
  [libc][NFC] Use ASSERT_FP_EQ to comapre NaN values in tests.

This is a continuation of the previous CL which did a similar change in
other tests. To elaborate a little about why we need this - under C++
compilation with headers not from LLVM libc, libraries like libc++ and
libstdc++ provide their own math.h which undefine macros like `isnan`
and provide the overloaded C++ isnan functions which return a boolean
value instead of an integer value returned by the isnan macro.




More information about the All-commits mailing list