[all-commits] [llvm/llvm-project] 9ead4e: [lldb] [Process/FreeBSDRemote] Replace GetRegister...

[Michał Górny via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9ead4e7b4a68d162122d861f5d5b6a3baf8d23c1
      https://github.com/llvm/llvm-project/commit/9ead4e7b4a68d162122d861f5d5b6a3baf8d23c1
  Author: Michał Górny <mgorny at moritz.systems>
  Date:   2020-12-17 (Thu, 17 Dec 2020)

  Changed paths:
    M lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.cpp

  Log Message:
  -----------
  [lldb] [Process/FreeBSDRemote] Replace GetRegisterSetCount()

Replace the wrong code in GetRegisterSetCount() with a constant return.
The original code passed register index in place of register set index,
effectively getting always true.  Correcting the code to check for
register set existence is not possible as LLDB supports only eliminating
last register sets.  Just return the full number for now which should
be NFC.

Differential Revision: https://reviews.llvm.org/D93396


  Commit: 835f8de8508953f4624534e36d54cd256e8800c9
      https://github.com/llvm/llvm-project/commit/835f8de8508953f4624534e36d54cd256e8800c9
  Author: Michał Górny <mgorny at moritz.systems>
  Date:   2020-12-17 (Thu, 17 Dec 2020)

  Changed paths:
    M lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.cpp
    M lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.h

  Log Message:
  -----------
  [lldb] [Process/FreeBSDRemote] Use RegSetKind consistently [NFC]

Use RegSetKind enum for register sets everything, rather than int.
Always spell it as 'RegSetKind', without unnecessary 'enum'.  Add
missing switch case.  While at it, use uint32_t for regnums
consistently.

Differential Revision: https://reviews.llvm.org/D93450


Compare: https://github.com/llvm/llvm-project/compare/17b3ff511c0a...835f8de85089