[all-commits] [llvm/llvm-project] 122a4e: Revert "[lldb] Make CommandInterpreter's execution...

Pavel Labath via All-commits all-commits at lists.llvm.org
Thu Dec 17 08:48:15 PST 2020


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 122a4ebde3f4394a84e9f93b9c7085f088be6dd7
      https://github.com/llvm/llvm-project/commit/122a4ebde3f4394a84e9f93b9c7085f088be6dd7
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2020-12-17 (Thu, 17 Dec 2020)

  Changed paths:
    M lldb/include/lldb/Interpreter/CommandInterpreter.h
    M lldb/source/API/SBCommandInterpreter.cpp
    M lldb/source/Breakpoint/BreakpointOptions.cpp
    M lldb/source/Commands/CommandObjectCommands.cpp
    M lldb/source/Commands/CommandObjectExpression.cpp
    M lldb/source/Commands/CommandObjectProcess.cpp
    M lldb/source/Commands/CommandObjectRegexCommand.cpp
    M lldb/source/Commands/CommandObjectSettings.cpp
    M lldb/source/Commands/CommandObjectWatchpointCommand.cpp
    M lldb/source/Core/IOHandlerCursesGUI.cpp
    M lldb/source/Interpreter/CommandInterpreter.cpp
    M lldb/source/Target/Target.cpp
    R lldb/test/API/python_api/debugger/Makefile
    M lldb/test/API/python_api/debugger/TestDebuggerAPI.py
    R lldb/test/API/python_api/debugger/main.cpp

  Log Message:
  -----------
  Revert "[lldb] Make CommandInterpreter's execution context the same as debugger's one."

This reverts commit a01b26fb51c710a3a8ef88cc83b0701461f5b9ab, because it
breaks the "finish" command in some way -- the command does not
terminate after it steps out, but continues running the target. The
exact blast radius is not clear, but it at least affects the usage of
the "finish" command in TestGuiBasicDebug.py. The error is *not*
gui-related, as the same issue can be reproduced by running the same
steps outside of the gui.

There is some kind of a race going on, as the test fails only 20% of the
time on the buildbot.




More information about the All-commits mailing list