[all-commits] [llvm/llvm-project] b60783: [libomptarget][nfc] Replace static const with enum

Jon Chesterfield via All-commits all-commits at lists.llvm.org
Wed Dec 16 08:41:03 PST 2020


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b607837c75d04cc007dcf855983dfa3b69f63d73
      https://github.com/llvm/llvm-project/commit/b607837c75d04cc007dcf855983dfa3b69f63d73
  Author: Jon Chesterfield <jonathanchesterfield at gmail.com>
  Date:   2020-12-16 (Wed, 16 Dec 2020)

  Changed paths:
    M openmp/libomptarget/deviceRTLs/amdgcn/src/target_impl.h
    M openmp/libomptarget/deviceRTLs/nvptx/src/target_impl.h

  Log Message:
  -----------
  [libomptarget][nfc] Replace static const with enum

[libomptarget][nfc] Replace static const with enum

Semantically identical. Replaces 0xff... with ~0 to spare counting the f.
Has the advantage that the compiler doesn't need to prove the 4/8 byte
value dead before discarding it, and sidesteps the compilation question
associated with what static means for a single source language.

Reviewed By: jdoerfert

Differential Revision: https://reviews.llvm.org/D93328




More information about the All-commits mailing list