[all-commits] [llvm/llvm-project] 20d0cb: [mlir] Tighten type verifiers for LLVM dialect ops...

[ftynse via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 20d0cbd3fadf5a6e78373ab5c9d35e9e5d49f172
      https://github.com/llvm/llvm-project/commit/20d0cbd3fadf5a6e78373ab5c9d35e9e5d49f172
  Author: Alex Zinenko <zinenko at google.com>
  Date:   2020-12-15 (Tue, 15 Dec 2020)

  Changed paths:
    M mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td
    M mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp
    M mlir/test/Dialect/LLVMIR/invalid.mlir

  Log Message:
  -----------
  [mlir] Tighten type verifiers for LLVM dialect ops results

Now that we have predicates for LLVM dialect types in ODS, we can use them to
restrict the types allowed in results of LLVM dialect operations. This also
serves as additional documentation for these operations.

Reviewed By: rriddle

Differential Revision: https://reviews.llvm.org/D93329


  Commit: 02220f3204980496c8877abb51ba1fd87a108541
      https://github.com/llvm/llvm-project/commit/02220f3204980496c8877abb51ba1fd87a108541
  Author: Alex Zinenko <zinenko at google.com>
  Date:   2020-12-15 (Tue, 15 Dec 2020)

  Changed paths:
    M mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td

  Log Message:
  -----------
  [mlir] NFC: retire LLVM_Zero/OneResultOp from LLVM dialect ODS

These classes were initially introduced to factor out two common parts of LLVM
op definitions: the fact that they have no results or a single result of
LLVM_Type, and the default builders. Neither of the two parts is really
common anymore: many ops have more specific on the result type, and many ops
provide custom builders. The TableGen classes only add conceptual complexity
and make LLVM dialect definition dissimilar to other dialects. Remove them in
favor of explicitly specified builders (results are already specified).

Depends On D93329

Reviewed By: rriddle

Differential Revision: https://reviews.llvm.org/D93330


Compare: https://github.com/llvm/llvm-project/compare/c4736b91f87e...02220f320498