[all-commits] [llvm/llvm-project] cfa101: [clangd] Provide suggestions with invalid config keys

Nathan James via All-commits all-commits at lists.llvm.org
Tue Dec 15 10:16:40 PST 2020


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: cfa1010c42429f689186125270dfbad7d6a1c01d
      https://github.com/llvm/llvm-project/commit/cfa1010c42429f689186125270dfbad7d6a1c01d
  Author: Nathan James <n.james93 at hotmail.co.uk>
  Date:   2020-12-15 (Tue, 15 Dec 2020)

  Changed paths:
    M clang-tools-extra/clangd/ConfigYAML.cpp
    M clang-tools-extra/clangd/test/config.test
    M clang-tools-extra/clangd/unittests/ConfigProviderTests.cpp
    M clang-tools-extra/clangd/unittests/ConfigYAMLTests.cpp

  Log Message:
  -----------
  [clangd] Provide suggestions with invalid config keys

Update the config file warning when an unknown key is detected which is likely a typo by suggesting the likely key.
This won't suggest a key that has already been seen in the block.

Appends the fix to the diag, however right now there is no support for presenting that fix to the user.

Reviewed By: sammccall

Differential Revision: https://reviews.llvm.org/D92990




More information about the All-commits mailing list