[all-commits] [llvm/llvm-project] a3bd67: SeparateConstOffsetFromGEP::lowerToSingleIndexGEPs...

Simon Pilgrim via All-commits all-commits at lists.llvm.org
Tue Dec 15 09:28:33 PST 2020


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a3bd67f222ca56d86f4d1da613fca9d0bef34d9b
      https://github.com/llvm/llvm-project/commit/a3bd67f222ca56d86f4d1da613fca9d0bef34d9b
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2020-12-15 (Tue, 15 Dec 2020)

  Changed paths:
    M llvm/lib/Transforms/Scalar/SeparateConstOffsetFromGEP.cpp

  Log Message:
  -----------
  SeparateConstOffsetFromGEP::lowerToSingleIndexGEPs - don't use dyn_cast_or_null. NFCI.

ResultPtr is guaranteed to be non-null - and using dyn_cast_or_null causes unnecessary static analyzer warnings.

We can't say the same for FirstResult AFAICT, so keep dyn_cast_or_null for that.


  Commit: 712117338ad81e2c661a5a658b795eb1993b841e
      https://github.com/llvm/llvm-project/commit/712117338ad81e2c661a5a658b795eb1993b841e
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2020-12-15 (Tue, 15 Dec 2020)

  Changed paths:
    M llvm/lib/Target/X86/X86ISelLowering.cpp

  Log Message:
  -----------
  [X86] Explicitly use SDValue instead of auto. NFCI.

Fix static analyzer warning about not using a SDValue&


Compare: https://github.com/llvm/llvm-project/compare/aa7ae25613da...712117338ad8


More information about the All-commits mailing list