[all-commits] [llvm/llvm-project] 1d3f1e: Revert "[lldb/API] Expose Target::CreateBreakpoint...

Med Ismail Bennani via All-commits all-commits at lists.llvm.org
Mon Dec 14 22:00:22 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 1d3f1eb855fcfb03b6ddb92543c02694115b5739
      https://github.com/llvm/llvm-project/commit/1d3f1eb855fcfb03b6ddb92543c02694115b5739
  Author: Med Ismail Bennani <medismail.bennani at gmail.com>
  Date:   2020-12-15 (Tue, 15 Dec 2020)

  Changed paths:
    M lldb/bindings/interface/SBTarget.i
    M lldb/include/lldb/API/SBTarget.h
    M lldb/source/API/SBTarget.cpp
    M lldb/test/API/functionalities/breakpoint/breakpoint_by_line_and_column/TestBreakpointByLineAndColumn.py

  Log Message:
  -----------
  Revert "[lldb/API] Expose Target::CreateBreakpoint(..., move_to_nearest_code) overload"

This reverts commit 04696ff002e7d311887b7b7e6e171340a0623dd9.

Exposing the LazyBool private type in SBTarget.h breaks some tests.


  Commit: dc82890a77fe894e90103f4465bb4c838617feff
      https://github.com/llvm/llvm-project/commit/dc82890a77fe894e90103f4465bb4c838617feff
  Author: Med Ismail Bennani <medismail.bennani at gmail.com>
  Date:   2020-12-15 (Tue, 15 Dec 2020)

  Changed paths:
    M lldb/bindings/interface/SBTarget.i
    M lldb/include/lldb/API/SBTarget.h
    M lldb/source/API/SBTarget.cpp
    M lldb/test/API/functionalities/breakpoint/breakpoint_by_line_and_column/TestBreakpointByLineAndColumn.py

  Log Message:
  -----------
  [lldb/API] Expose Target::CreateBreakpoint(..., move_to_nearest_code) overload

This patch exposes the Target::CreateBreakpoint overload with the
boolean argument to move to the neareast code to the SBAPI.

This is useful when creating column breakpoints to restrict lldb's
resolution to the pointed source location, preventing it to go to the next
line.

rdar://72196842

Differential Revision: https://reviews.llvm.org/D93266

Signed-off-by: Med Ismail Bennani <medismail.bennani at gmail.com>


Compare: https://github.com/llvm/llvm-project/compare/a6805a0e02c9...dc82890a77fe


More information about the All-commits mailing list