[all-commits] [llvm/llvm-project] d2ed9d: Revert "ADT: Migrate users of AlignedCharArrayUnio...

[Reid Kleckner via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: d2ed9d6b7ec6ae837aac0b2d2920c1e34b89d00b
      https://github.com/llvm/llvm-project/commit/d2ed9d6b7ec6ae837aac0b2d2920c1e34b89d00b
  Author: Reid Kleckner <rnk at google.com>
  Date:   2020-12-14 (Mon, 14 Dec 2020)

  Changed paths:
    M clang/include/clang/AST/APValue.h
    M clang/include/clang/AST/ASTContext.h
    M clang/include/clang/AST/ASTTypeTraits.h
    M clang/include/clang/AST/ParentMapContext.h
    M clang/include/clang/Frontend/PrecompiledPreamble.h
    M clang/include/clang/Sema/Overload.h
    M clang/lib/DirectoryWatcher/linux/DirectoryWatcher-linux.cpp
    M clang/lib/DirectoryWatcher/windows/DirectoryWatcher-windows.cpp
    M clang/lib/Lex/PPDirectives.cpp
    M llvm/include/llvm/ADT/DenseMap.h
    M llvm/include/llvm/ADT/IntervalMap.h
    M llvm/include/llvm/CodeGen/DIE.h
    M llvm/include/llvm/CodeGen/SelectionDAGNodes.h
    A llvm/include/llvm/Support/AlignOf.h
    M llvm/include/llvm/Support/Error.h
    M llvm/include/llvm/Support/ErrorOr.h
    M llvm/include/llvm/Support/JSON.h
    M llvm/include/llvm/Support/TrailingObjects.h
    M llvm/include/llvm/Support/YAMLTraits.h
    M llvm/lib/Transforms/InstCombine/InstCombineAddSub.cpp
    A llvm/unittests/Support/AlignOfTest.cpp
    M llvm/unittests/Support/CMakeLists.txt

  Log Message:
  -----------
  Revert "ADT: Migrate users of AlignedCharArrayUnion to std::aligned_union_t, NFC"

We determined that the MSVC implementation of std::aligned* isn't suited
to our needs. It doesn't support 16 byte alignment or higher, and it
doesn't really guarantee 8 byte alignment. See
https://github.com/microsoft/STL/issues/1533

Also reverts "ADT: Change AlignedCharArrayUnion to an alias of std::aligned_union_t, NFC"

Also reverts "ADT: Remove AlignedCharArrayUnion, NFC" to bring back
AlignedCharArrayUnion.

This reverts commit 4d8bf870a82765eb0d4fe53c82f796b957c05954.

This reverts commit d10f9863a5ac1cb681af07719650c44b48f289ce.

This reverts commit 4b5dc150b9862271720b3d56a3e723a55dd81838.