[all-commits] [llvm/llvm-project] b3d1d1: [libc++] Remove unnecessary static assertion in al...

Louis Dionne via All-commits all-commits at lists.llvm.org
Mon Dec 14 14:48:15 PST 2020


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b3d1d1f4fff816423ea8c652d8d849aacc4c6ce8
      https://github.com/llvm/llvm-project/commit/b3d1d1f4fff816423ea8c652d8d849aacc4c6ce8
  Author: Louis Dionne <ldionne.2 at gmail.com>
  Date:   2020-12-14 (Mon, 14 Dec 2020)

  Changed paths:
    M libcxx/include/memory
    R libcxx/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.create/allocate_shared.protected.verify.cpp
    R libcxx/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.create/make_shared.protected.verify.cpp

  Log Message:
  -----------
  [libc++] Remove unnecessary static assertion in allocate_shared

Checking that `T` is constructible from `Args...` is technically not
required by the Standard, although any implementation will obviously
error out if that's not satisfied. However, this check is incompatible
with using Allocator construction in the control block (upcoming change
as part of implementing P0674), so I'm removing it now to reduce the
upcoming diff as much as possible.

Differential Revision: https://reviews.llvm.org/D93246




More information about the All-commits mailing list