[all-commits] [llvm/llvm-project] d78484: [TableGen] Fixed 64-bit filters being sliced to 32...

[llvmbot via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: d784845de1f0c97a053aab281985fa4be40fcc87
      https://github.com/llvm/llvm-project/commit/d784845de1f0c97a053aab281985fa4be40fcc87
  Author: Cameron Desrochers <Cameron.Desrochers at octasic.com>
  Date:   2020-12-14 (Mon, 14 Dec 2020)

  Changed paths:
    M llvm/utils/TableGen/FixedLenDecoderEmitter.cpp

  Log Message:
  -----------
  [TableGen] Fixed 64-bit filters being sliced to 32 bits in FixedLenDecoderEmitter

When using the FixedLenDecoderEmitter, llvm-tblgen emits tables with (OPC_ExtractField, OPC_ExtractFilterValue) opcode sequences to match the contiguous fixed bits of a given instruction's encoding. This encoding is represented in a 64-bit integer. However, the filter values were represented in a 32-bit integer. As such, instructions with fixed 64-bit encodings resulted in a table with an OPC_ExtractField for all 64 bits, followed by an OPC_ExtractFilterValue containing just the low 32 bits of their encoding, causing the filter never to match.

The exact point at which the slicing occurred was during the map insertion at line 630.

Differential Revision: https://reviews.llvm.org/D92423