[all-commits] [llvm/llvm-project] d380c3: [YAML] Use correct source location for unknown key...

[Nathan James via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d380c38e3470c5b02a3002a7ea8d836f44086b31
      https://github.com/llvm/llvm-project/commit/d380c38e3470c5b02a3002a7ea8d836f44086b31
  Author: Nathan James <n.james93 at hotmail.co.uk>
  Date:   2020-12-11 (Fri, 11 Dec 2020)

  Changed paths:
    M llvm/include/llvm/Support/YAMLParser.h
    M llvm/include/llvm/Support/YAMLTraits.h
    M llvm/lib/Support/YAMLParser.cpp
    M llvm/lib/Support/YAMLTraits.cpp
    M llvm/test/CodeGen/MIR/X86/spill-slot-fixed-stack-object-aliased.mir
    M llvm/test/CodeGen/MIR/X86/spill-slot-fixed-stack-object-immutable.mir
    M llvm/test/CodeGen/MIR/X86/variable-sized-stack-object-size-error.mir
    M llvm/test/Object/nm-tapi-invalids.test
    M llvm/unittests/TextAPI/TextStubV1Tests.cpp
    M llvm/unittests/TextAPI/TextStubV2Tests.cpp
    M llvm/unittests/TextAPI/TextStubV3Tests.cpp
    M llvm/unittests/TextAPI/TextStubV4Tests.cpp

  Log Message:
  -----------
  [YAML] Use correct source location for unknown key errors.

Currently unknown keys when inputting mapping traits have the location set to the Value.
Example:
```
YAML:1:14: error: unknown key 'UnknownKey'
{UnknownKey: SomeValue}
             ^~~~~~~~~
```
This is unhelpful for a user as it draws them to fix the wrong item.

Reviewed By: silvas

Differential Revision: https://reviews.llvm.org/D93037