[all-commits] [llvm/llvm-project] ce93de: [libomptarget][nfc] Remove data_sharing type aliasing

Jon Chesterfield via All-commits all-commits at lists.llvm.org
Thu Dec 10 18:18:39 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: ce93de3bb284c944676c7b81890156d9d80b1db9
      https://github.com/llvm/llvm-project/commit/ce93de3bb284c944676c7b81890156d9d80b1db9
  Author: Jon Chesterfield <jonathanchesterfield at gmail.com>
  Date:   2020-12-11 (Fri, 11 Dec 2020)

  Changed paths:
    M openmp/libomptarget/deviceRTLs/common/omptarget.h
    M openmp/libomptarget/deviceRTLs/interface.h

  Log Message:
  -----------
  [libomptarget][nfc] Remove data_sharing type aliasing

[libomptarget][nfc] Remove data_sharing type aliasing

Libomptarget previous used __kmpc_data_sharing_slot to access values of type
__kmpc_data_sharing_{worker,master}_slot_static. This aliasing violation was
benign in practice. The master type has since been removed, so a single type
can be used instead.

This is particularly helpful for the transition to an openmp deviceRTL, as the
c++/openmp compiler for amdgcn currently rejects the flexible array member for
being an incomplete type. Serves the same purpose as abandoned D86324.

Reviewed By: jdoerfert

Differential Revision: https://reviews.llvm.org/D93075




More information about the All-commits mailing list