[all-commits] [llvm/llvm-project] 456455: [WebAssembly] Support COMDAT sections in assembly ...

Derek Schuff via All-commits all-commits at lists.llvm.org
Thu Dec 10 14:46:58 PST 2020


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4564553b8d8ab81dc21431a35275581cb42329c8
      https://github.com/llvm/llvm-project/commit/4564553b8d8ab81dc21431a35275581cb42329c8
  Author: Derek Schuff <dschuff at chromium.org>
  Date:   2020-12-10 (Thu, 10 Dec 2020)

  Changed paths:
    M llvm/lib/MC/MCParser/WasmAsmParser.cpp
    M llvm/lib/MC/MCSectionWasm.cpp
    M llvm/lib/MC/WasmObjectWriter.cpp
    M llvm/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp
    M llvm/test/MC/WebAssembly/comdat-sections.ll
    A llvm/test/MC/WebAssembly/comdat-sections.s
    M llvm/test/MC/WebAssembly/comdat.ll

  Log Message:
  -----------
  [WebAssembly] Support COMDAT sections in assembly syntax

This CL changes the asm syntax for section flags, making them more like ELF
(previously "passive" was the only option). Now we also allow "G" to designate
COMDAT group sections. In these sections we set the appropriate comdat flag on
function symbols, and also avoid auto-creating a new section for them.

This also adds asm-based tests for the changes D92691 to go along with
the direct-to-object tests.

Differential Revision: https://reviews.llvm.org/D92952




More information about the All-commits mailing list